Fixes #1369 - Projections inherited from a base class that hides the Id property, projects to an empty Id. #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
changed the title
oskardudycz
changed the title
mysticmind
reviewed
Oct 19, 2019
src/Marten/StoreOptions.cs
Outdated
| @@ -219,9 +219,22 @@ public void Serializer(ISerializer serializer) | |||
| /// <param name="enumStyle"></param> | |||
| /// <param name="casing">Casing style to be used in serialization</param> | |||
| /// <param name="collectionStorage">Allow to set collection storage as raw arrays (without explicit types)</param> | |||
| public void UseDefaultSerialization(EnumStorage enumStyle = EnumStorage.AsInteger, Casing casing = Casing.Default, CollectionStorage collectionStorage = CollectionStorage.Default) | |||
| /// <param name="nonPublicMembersStorage">Allow to use non public members should be used during deserialization</param> | |||
There was a problem hiding this comment.
Change to "Allow non public members to be used during deserialization"
oskardudycz
force-pushed
the
feature/GH-1369
branch
from
359740c to
471a9e8
Compare
|
@mysticmind thank you for the review. I'll update the docs and ping you when they're ready. |
…ted to allow eg. having private or protected setter for ID
…rialization settings, added unit tests for non public id setter
…cumentation of other Newtonsoft.NET Serializer options
oskardudycz
force-pushed
the
feature/GH-1369
branch
from
60630c7 to
be74783
Compare
|
@mysticmind I updated the documentation in be74783. |
mysticmind
approved these changes
Nov 3, 2019
|
Thank you @mysticmind - updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GetProperties to also return private and protected to allow eg. having a private or protected setter for ID.
Added
NonPublicMembersStorageto allowprivateandprotectedsetters usage during properties (de)serialization and non-default constructor usage (although full support - so removing the limitation of the view having public constructor will be changed in the separate PR).Added documentation for missing Newtonsoft.NET serializer options.
Fixes #1369
@jediwarpraptor @ddivita fyi