Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1372 - thread safety of storage setup #1373

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Fixes #1372 - thread safety of storage setup #1373

merged 1 commit into from
Oct 19, 2019

Conversation

barryhagan
Copy link
Contributor

  • move name check inside the lock,
  • only load the schema objects once to do this,
  • don't re-run checks on race conditions

@barryhagan
Fixes JasperFx#1372 - move name check inside the lock, only load the …
37a47b7 
…schema objects once, don't re-run check on race condition
oskardudycz
oskardudycz approved these changes Oct 19, 2019
View reviewed changes
Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Nice fix @barryhagan 👍

@oskardudycz oskardudycz added this to the 3.10.0 milestone Oct 19, 2019
mysticmind
mysticmind approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@mysticmind mysticmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mysticmind mysticmind merged commit 75d4bb0 into JasperFx:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskardudycz oskardudycz oskardudycz approved these changes

@mysticmind mysticmind mysticmind approved these changes

@jeremydmiller jeremydmiller Awaiting requested review from jeremydmiller

@jokokko jokokko Awaiting requested review from jokokko

Assignees
No one assigned
Labels
bug schema management
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@barryhagan @mysticmind @oskardudycz