Skip to content

Comments

Pulsar support for retry and DLQ#1333

Merged
jeremydmiller merged 44 commits intoJasperFx:mainfrom
punxrok:pulsar-support-retry-and-DLQ
Feb 6, 2026
Merged

Pulsar support for retry and DLQ#1333
jeremydmiller merged 44 commits intoJasperFx:mainfrom
punxrok:pulsar-support-retry-and-DLQ

Conversation

@punxrok
Copy link
Contributor

@punxrok punxrok commented Mar 26, 2025

Pulsar support for retry and DLQ

@punxrok
Copy link
Contributor Author

punxrok commented Mar 27, 2025

Hey @jeremydmiller
can you please check #1333, especially the TODO: comments (like in PulsarListener.MoveToErrorsAsync(...)), where I would need some guidance.

@punxrok punxrok marked this pull request as ready for review March 31, 2025 13:04
… MoveToRetryLetterQueueAsync from the lifecycle
@jeremydmiller
Copy link
Member

@punxrok Couple things:

  • I'm concerned with how many files got touched here, and you introduced all new concepts into the core framework
  • How is the retry queue any different than Wolverine's existing re-queue mechanism? Why do we need an all new concept?
  • Why can't the DLQ fit into Wolverine's existing native DLQ abstractions? Why do we need all new abstractions just for Pulsar?

Rok Povodnik added 6 commits April 14, 2025 11:56
…be deleted in next commit) with ISupportNativeScheduling for Pulsar's native retry letter functionality.
…viously modified code - removed DotPulsar.Extensions.Resiliency (retry and delay message functionality was not working properly) and created "in-house" retry and DLQ functionalities
Rok Povodnik and others added 8 commits January 27, 2026 16:40
# Conflicts:
#	src/Transports/Pulsar/Wolverine.Pulsar/PulsarTransportExtensions.cs
Co-authored-by: punxrok <6354783+punxrok@users.noreply.github.com>

# Conflicts:
#	src/Transports/Pulsar/Wolverine.Pulsar.Tests/Wolverine.Pulsar.Tests.csproj
#	src/Transports/Pulsar/Wolverine.Pulsar/Wolverine.Pulsar.csproj
…guidelines

Co-authored-by: punxrok <6354783+punxrok@users.noreply.github.com>
…y constant

Co-authored-by: punxrok <6354783+punxrok@users.noreply.github.com>
Pulsar: stabilize native retry/DLQ, add tests
- Fix PulsarListener resiliency logic, ack handling, and exception headers
- Add retry consumer tracking and IPv4 URL for Podman tests
- Disable parallelization for Pulsar integration tests
- Add unit tests for resiliency config
- Verify PulsarNativeReliabilityTests pass under Podman
…ests

The tests were failing due to a race condition where the tracking session
completed before all requeued messages were processed, resulting in 0
requeued messages being tracked instead of the expected count.
@punxrok
Copy link
Contributor Author

punxrok commented Jan 28, 2026

Hey @jeremydmiller, sorry for such a late reply. I rebased it as you requested (old commits were made on old 4.* Wolverine branch).

@jeremydmiller
Copy link
Member

@punxrok Hey man, I'm so, so sorry this slipped. I'll try to get this in tomorrow for 5.13.

@jeremydmiller
Copy link
Member

I'll deal w/ the rebase after your last commits

@jeremydmiller jeremydmiller added this to the 5.15 milestone Feb 4, 2026
@jeremydmiller
Copy link
Member

@punxrok This finally got in, but I made a new PR w/ your changes:

#2122

@jeremydmiller
Copy link
Member

Totally misspoke, NOW it's going to go in soon.

@jeremydmiller
Copy link
Member

I'm pulling this in now and fixing whatever is up in main. Looks like just Nuget ref problems so far.

@jeremydmiller jeremydmiller merged commit 6a62733 into JasperFx:main Feb 6, 2026
2 of 4 checks passed
@jeremydmiller jeremydmiller mentioned this pull request Feb 6, 2026
9 tasks
@punxrok
Copy link
Contributor Author

punxrok commented Feb 6, 2026

Thanks, @jeremydmiller! No worries about the delay at all. I really appreciate you handling the rebase and those NuGet-related fixes.

@jeremydmiller
Copy link
Member

@punxrok Appreciate your patience. I do pride myself on getting PRs and issues taken care of reasonably quick, but sometimes things do fall through the cracks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants