Experimental changes to envelope serialization#2102
Merged
jeremydmiller merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
jorik
reviewed
Feb 6, 2026
| catch (NotSupportedException) | ||
| { | ||
| // Buffer was too small, fall back to expandable stream | ||
| ReturnBuffer(buffer); |
Contributor
There was a problem hiding this comment.
I was looking at the code, and saw you're returning the buffer twice @jeremydmiller. Once here in the catched exception, and then again in the finally
This will return the same buffer twice to the pool, causing future Rent() calls to return the same array to 2 different callers, which can cause some nasty issues
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.