Preserve failure policies on stubbed message handlers#2143
Merged
jeremydmiller merged 1 commit intomainfrom Feb 9, 2026
Merged
Preserve failure policies on stubbed message handlers#2143jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
StubTransport.BuildFor() was creating Executors with an empty FailureRuleCollection, discarding all chain-level and global error handling policies (retries, discard, custom failure actions). Now looks up the original HandlerChain's failure rules and timeout, matching the behavior of the normal Executor.Build() path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StubTransport.BuildFor()was creatingExecutorinstances with an emptyFailureRuleCollection, discarding all chain-level and global error handling policies (retries, discard, custom failure actions)HandlerChain's failure rules via_runtime.Handlers.ChainFor(messageType)and combines them with global rules, matching the behavior of the normalExecutor.Build()pathTest plan
RetryWithCooldownand custom failure policies in integration tests🤖 Generated with Claude Code