Harden Postgresql AdvisoryLock against closed connections during shutdown#2172
Merged
jeremydmiller merged 1 commit intomainfrom Feb 12, 2026
Merged
Harden Postgresql AdvisoryLock against closed connections during shutdown#2172jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…down Catch exceptions in ReleaseLockAsync and DisposeAsync when the connection is already broken or closed, which occurs during graceful shutdown in multi-replica environments. Fixes double-dispose bug and checks connection state before attempting close operations. Closes GH-2146 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReleaseLockAsyncwhen the underlying connection is broken during shutdown, preventingNpgsqlException: Exception while reading from streamConnectionState.Openbefore attempting to release locks or close the connection inDisposeAsync, preventingInvalidOperationException: Connection is not openDisposeAsyncwas called on the connection in both catch and finally blockssafeCloseConnectionAsync()helper that guards all close/dispose operations with state checks and try/catchDisposeAsyncCloses #2146
Test plan
🤖 Generated with Claude Code