Skip to content

Comments

Avoid running a query when there's nothing to do#2201

Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom
PerfectlyNormal:fix/unnecessary-dbcall
Feb 17, 2026
Merged

Avoid running a query when there's nothing to do#2201
jeremydmiller merged 1 commit intoJasperFx:mainfrom
PerfectlyNormal:fix/unnecessary-dbcall

Conversation

@PerfectlyNormal
Copy link
Contributor

Was debugging a different problem we've been experiencing and caught an exception when it attempted to reassign incoming envelopes. It got called with 0 envelopes, built an empty SQL command and that threw an exception.

Haven't noticed any issues or logs related to this, so guessing it gets caught and handled somewhere, but feels unnecessary to open a connection when we know it won't work ahead of time.

@jeremydmiller
Copy link
Member

Huh, wonder how this hasn't come up before.

@jeremydmiller jeremydmiller merged commit da1d64f into JasperFx:main Feb 17, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants