Fix endpoints with multiple [Document] args (GH-2205)#2206
Merged
jeremydmiller merged 1 commit intomainfrom Feb 17, 2026
Merged
Fix endpoints with multiple [Document] args (GH-2205)#2206jeremydmiller merged 1 commit intomainfrom
jeremydmiller merged 1 commit intomainfrom
Conversation
…H-2205) LoadDocumentFrame.FindVariables() was not yielding _sagaId, so MartenBatchFrame didn't know about the route value dependency. This caused batch query code to be emitted before route values were extracted for the 2nd+ document parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoadDocumentFrame.FindVariables()was not yielding_sagaId, soMartenBatchFramedidn't propagate the route value dependency. This caused batch query code to be emitted before route values were extracted for the 2nd+[Document]parameters, producing invalid generated code.yield return _sagaId;to match the pattern already used byLoadAggregateFrame[Document]params and mixed[Document]+[Aggregate]params, including 404 casesTest plan
Closes #2205
🤖 Generated with Claude Code