Relax Jax version #103
Merged
Relax Jax version #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 98.96% 98.95% -0.01%
==========================================
Files 13 13
Lines 962 960 -2
==========================================
- Hits 952 950 -2
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@daniel-dodd - can I get a quick review on this please? There's no frontend changes, it simply lets us relax the Jax version. |
daniel-dodd
reviewed
Aug 23, 2022
daniel-dodd
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
@thomaspinder This PR looks good to me.
For consistency, please rename "unit-Gaussian" to "unit Gaussian" in the warning message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the strict Jax requirement present in previous version of GPJax. This should resolve #102
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Right now we cannot use Jax versions beyond 0.3.5. By extending the distrax bijectors and updating some Jax tree-based operations, we can simply make this versioning an inequality to install the latest Jax version.
Issue Number: #102