Page storage bug fix (pingcap#87)

* add test cases for PageStorage * split PageStorage gc stage into small helper functions * add test cases for PageStorage gc concurrency * add stress test and dump utils of PageStorage * Fix bug: 1. ensure PageFile with meta && data, in case gc drop file but be killed before drop dir 2. turn PageStorage::Config::sync_on_write = true by default 3. avoid PageStorage::gc run by multi-threads 4. print PageFile's path if checksum is not correct * throw exception for must_exist==false and errno != ENOENT
JaySon-Huang · Sep 5, 2019 · bfb4475 · bfb4475
1 parent ebd792b
commit bfb4475
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/dbms/src/Storages/CMakeLists.txt b/dbms/src/Storages/CMakeLists.txt
@@ -6,3 +6,4 @@ if (ENABLE_TESTS)
     add_subdirectory (Page/tests EXCLUDE_FROM_ALL)
     add_subdirectory (DeltaMerge/tests EXCLUDE_FROM_ALL)
 endif ()
+
diff --git a/dbms/src/Storages/Page/tests/CMakeLists.txt b/dbms/src/Storages/Page/tests/CMakeLists.txt
@@ -29,3 +29,4 @@ target_compile_options(page_utils_get_valid_pages PRIVATE -Wno-format)
 add_executable(test_page_storage_write_disk_full test_page_storage_write_disk_full.cpp)
 target_link_libraries(test_page_storage_write_disk_full dbms)
 target_compile_options(test_page_storage_write_disk_full PRIVATE -Wno-format)
+
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,3 +6,4 @@ if (ENABLE_TESTS)
		add_subdirectory (Page/tests EXCLUDE_FROM_ALL)
		add_subdirectory (DeltaMerge/tests EXCLUDE_FROM_ALL)
		endif ()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,3 +29,4 @@ target_compile_options(page_utils_get_valid_pages PRIVATE -Wno-format)
		add_executable(test_page_storage_write_disk_full test_page_storage_write_disk_full.cpp)
		target_link_libraries(test_page_storage_write_disk_full dbms)
		target_compile_options(test_page_storage_write_disk_full PRIVATE -Wno-format)