Skip to content

Commit

Permalink
19034 rebase legal name branch (bcgov#556)
Browse files Browse the repository at this point in the history
* Add small rendering delay for Firefox, that way the review and confirm scrolls to the top of the screen. (bcgov#535)

* 17347 - Add in directors for corrections for CP. (bcgov#536)

* Add in directors for corrections for CP.

* Fix unit tests for director change for CP.

* Add in COOP.

* Add in appointmentDate for co-op corrections. (bcgov#537)

* Bump postcss from 8.4.30 to 8.4.31 (bcgov#533)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.30...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* - app version = 4.7.5 (bcgov#541)

- moved director workaround to LegalServices
- moved parties workaround to LegalServices
- removed workaround from Change
- removed workaround from Conversion
- updated unit tests

* - app version = 4.7.6 (bcgov#542)

- deleted obsolete "alteration-ui-enabled" FF
- deleted obsolete "change-ui-enabled" FF
- deleted obsolete "conversion-ui-enabled" FF
- removed flag usage from Alteration.vue
- removed flag usage from Change.vue
- removed flag usage from Conversion.vue
- removed flag usage from SpecialResolution.vue

* - app version = 4.7.7 (bcgov#543)

- uninstalled v-sanitize
- installed vue-sanitize-directive
- updated imports
- added "basic" option (same as default with old package)

* 17158 update fetchNameRequest (bcgov#540)

* 17158 update fetchNameRequest

* add debug code

* add debug --wip

* add debug --wip

* update error handling

* update NR status

* update version

* 18277 - Don't pre select no fee option for co-op correction. (bcgov#539)

* Don't pre select no fee option for co-op correction.

* Set to FAS, this way it will display $20.

* Update package version.

* Add in dropdown option for BEN when alterating from ULC (bcgov#545)

* add in dropdown option for BEN when going from ULC

* Name request check error update

* Update comment and package versions

* 18716 added phone number and email address to name request correction… (bcgov#547)

* 18716 added phone number and email address to name request correction on file and pay

* updated package json

* removed debug code

* 18728 - COOP Bug: Payment shows up as bcgov#3 when it should be bcgov#5 (bcgov#548)

* fix csr index bug

* 4.7.11

* 18735 - Fix rules showing up as being changed, when it's on paper (bcgov#549)

* Fix rules being changed, when it's on paper

* Fix bad code

* add in extra || null

* 18622 - Correction - Blank Special Resolution (bcgov#550)

* 18495 - Coop Correction Changes when the Resolution is Absent (bcgov#551)

* 18495 - Bug Fix - Show Resolution Section when not Correction Filing (bcgov#552)

* 19069 - Special Resolution - Validation on blank association type (bcgov#553)

* Bump vite from 4.3.9 to 4.5.2 (bcgov#555)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.9 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* major package version update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Travis Semple <travis8814@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com>
Co-authored-by: Kevin Zhang <54437031+kzdev420@users.noreply.github.com>
Co-authored-by: Paul <144158015+PaulGarewal@users.noreply.github.com>
Co-authored-by: Jia Xu <Jia.Xu@gov.bc.ca>
  • Loading branch information
7 people committed Jan 31, 2024
1 parent 18a6891 commit 56c4cc5
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.8.0",
"version": "5.0.0",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/components/common/YourCompany/AssociationType.vue
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ export default class AssociationType extends Mixins(CommonMixin) {
/** Reset association type value to original */
resetAssociationType () {
this.setBusinessInformation(this.getOriginalBusinessInfo || { ...EmptyBusinessInfo })
this.onComponentValidateChanged()
this.isEditingAssociationType = false
}
Expand Down
3 changes: 2 additions & 1 deletion src/components/common/YourCompany/ChangeBusinessType.vue
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ export default class ChangeBusinessType extends Mixins(CommonMixin) {
return true
}
// Named ULC to BC Limited require a name request.
if (this.getOriginalLegalType === CorpTypeCd.BC_ULC_COMPANY && this.isBcLimited) {
if (this.getOriginalLegalType === CorpTypeCd.BC_ULC_COMPANY &&
(this.isBcLimited || this.isBenefitCompany)) {
return true
}
return false
Expand Down

0 comments on commit 56c4cc5

Please sign in to comment.