Added amalgamation FF check (bcgov#610)

* Added amalgamation FF check

* Fixed unit tests

* typo

package.json

@@ -1,6 +1,6 @@
 {
  "name": "business-filings-ui",
- "version": "7.0.34",
+ "version": "7.0.35",
  "private": true,
  "appName": "Filings UI",
  "sbcName": "SBC Common Components",

src/components/EntityInfo/EntityMenu.vue

@@ -219,6 +219,7 @@
  >
  <template #activator="{ on }">
  <div
+ v-if="enableAmalgamation"
  v-on="on"
  >
  <v-list-item
@@ -295,6 +296,10 @@ export default class EntityMenu extends Mixins(AllowableActionsMixin) {
  return !!GetFeatureFlag('supported-agm-location-chg-entities').includes(this.getLegalType)
  }
 
+ get enableAmalgamation (): boolean {
+ return !!GetFeatureFlag('supported-amalgamation-entities').includes(this.getLegalType)
+ }
+
  /** The tooltip text for AGM Extension list item. Text is different if action item is disabled. */
  get agmExtensionToolTipText (): string {
  if (!this.isAllowed(AllowableActions.AGM_EXTENSION)) {

src/utils/feature-flags.ts

@@ -12,6 +12,7 @@ const defaultFlagSet: LDFlagSet = {
  'enable-digital-credentials': false,
  'sentry-enable': false, // by default, no sentry logs
  'show-alert-phone-numbers-firm': false,
+ 'supported-amalgamation-entities': [],
  'supported-business-summary-entities': [],
  'supported-correction-entities': [],
  'supported-dissolution-entities': [],

tests/unit/EntityMenu.spec.ts

@@ -292,7 +292,22 @@ describe('Entity Menu - View and Change Business Information click tests', () =>
  })
 })
 
-describe('Entity Menu - Amagamate button tests', () => {
+describe('Entity Menu - Amalgamate button tests', () => {
+ beforeAll(() => {
+ // override feature flag
+ vi.spyOn(utils, 'GetFeatureFlag').mockImplementation(flag => {
+ if (flag === 'supported-agm-extension-entities') return ''
+ if (flag === 'supported-agm-location-chg-entities') return ''
+ if (flag === 'supported-amalgamation-entities') return 'BC'
+ return null
+ })
+ })
+
+ afterAll(() => {
+ // restore feature flag
+ vi.spyOn(utils, 'GetFeatureFlag').mockRestore()
+ })
+
  it('displays the Amalgamate button', async () => {
  businessStore.setLegalType(CorpTypeCd.BC_COMPANY)
  businessStore.$state.businessInfo.state = EntityState.ACTIVE
@@ -559,6 +574,7 @@ describe('Entity Menu - Request AGM Extension click tests', () => {
  vi.spyOn(utils, 'GetFeatureFlag').mockImplementation(flag => {
  if (flag === 'supported-agm-extension-entities') return 'BEN'
  if (flag === 'supported-agm-location-chg-entities') return ''
+ if (flag === 'supported-amalgamation-entities') return ''
  return null
  })
  })
@@ -597,6 +613,7 @@ describe('Entity Menu - Request AGM Location Change click tests', () => {
  vi.spyOn(utils, 'GetFeatureFlag').mockImplementation(flag => {
  if (flag === 'supported-agm-extension-entities') return ''
  if (flag === 'supported-agm-location-chg-entities') return 'BEN'
+ if (flag === 'supported-amalgamation-entities') return ''
  return null
  })
  })