This repository has been archived by the owner on Feb 21, 2021. It is now read-only.
[Issue #485] Refactor easyiceconfig to use CMAKE_INSTALL_PREFIX #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Search python 2 executable as a new dependency. - Search python module "lib" path and stores it in a variable.
This replaces all hardcoded install prefixes ("/usr/local") with the
CMake variable CMAKE_INSTALL_PREFIX, allowing users to set their
favourite prefix.
|
I have tested this PR because I am doing parallelIce_py and I came well see this new CMakeLists. do not appear init or easyiceconfig.py |
|
Target wasn't running at all. Added to default target, and ready to recheck again @aitormf. |
|
All works well, I don't see any problem now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue #485 only for both easyiceconfig.
Note this PR is intended to be applied only if PR #530 is accepted, please check it first.