Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presence): fix presence not synchronizing states properly #7

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(presence): fix presence not synchronizing states properly #7

merged 1 commit into from
Nov 28, 2024

Conversation

timadevelop
Copy link
Contributor

Presence state sync did not work properly because:

  1. React was not picking up _presence changes because Presence.sync* methods expect mutable objects & return them as a result.
  2. The if statement on presence_diff discarded a valid case when empty prevState should be synced to a newDiff

Jdyn
Jdyn approved these changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@Jdyn Jdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this make sense.

lgtm

@Jdyn Jdyn merged commit f84b454 into Jdyn:main Nov 28, 2024
@timadevelop timadevelop deleted the fix/use-presence-sync branch November 28, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jdyn Jdyn Jdyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timadevelop @Jdyn