Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Windows short paths are resolved to long paths #50

Conversation

SuperValou
Copy link
Contributor

Fixes #49

This PR fixes an issue where Windows short names would not be resolved to their corresponding long names and cause rez-pip to raise an error.

@JeanChristopheMorinPerso
Copy link
Owner

Closing and re-opening to see if I can can the GH to trigger the tests.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #50 (59d040f) into main (f1a5080) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head 59d040f differs from pull request most recent head 214f68a. Consider uploading reports for the commit 214f68a to get more accurate results

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   77.55%   77.44%   -0.12%     
==========================================
  Files           8        8              
  Lines         704      705       +1     
  Branches      146      146              
==========================================
  Hits          546      546              
- Misses        150      151       +1     
  Partials        8        8              
Files Coverage Δ
src/rez_pip/rez.py 66.40% <0.00%> (-0.53%) ⬇️

Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit f0fa1e1 into JeanChristopheMorinPerso:main Oct 12, 2023
17 of 18 checks passed
@JeanChristopheMorinPerso
Copy link
Owner

Thanks @SuperValou! I just merged your PR and I'll see if I can release a new version today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rez-pip fails due to Windows short file names
2 participants