Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README code space and variable declarations #388

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

wozitto
Copy link
Contributor

@wozitto wozitto commented Apr 11, 2024

1. Changed code space from tab to two spaces

The space in the code block has been replaced by a tab from two spaces in the PR here.
When I look at the space with tabs in preview, I feel the space is too wide, so I will change it back to two spaces.

  • Current preview
スクリーンショット 2024-04-11 11 38 07
  • Preview after changes
スクリーンショット 2024-04-11 11 41 23

2. Changed let declarations to const declarations in the "Dynamic class names with ES2015" example

Since the const declaration has been available from ES2015, I have used it to maintain consistency with other implementation examples.

@wozitto wozitto changed the title Update README code space from tab to two spaces Update README code space and variable declarations Apr 11, 2024
@wozitto wozitto marked this pull request as ready for review April 11, 2024 02:54
@dcousens
Copy link
Collaborator

This project seems to using tabs typically, but I don't really mind when 2 space is relatively standard in Javascript and this is only documentation

@wozitto
Copy link
Contributor Author

wozitto commented Apr 11, 2024

@dcousens
Indeed, whether it is Tab or 2 space is a trivial difference.
However, since "Real-world example:" uses 2 space, I think it would be better to unify them for the sake of document consistency.
And at least to me it looks cleaner to use 2 space. 👀

@jonkoops
Copy link
Collaborator

I think this is a good thing to land, first and foremost because our documentation already uses inconsistent indentation in code examples. Secondarily because be default GitHub indentation for tabs is quite wide.

@jonkoops jonkoops merged commit 625ef35 into JedWatson:main Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants