Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check next props value against code mirror value #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

durran
Copy link

@durran durran commented Jun 28, 2017

We we having the same issues as described in #121 and #106. In our case, simply checking the next prop's value against the current code mirror value resolved the issue.

@OsamaShabrez
Copy link

Waiting for this PR to be merged. This solves our problem as well.

@marcofugaro
Copy link

please @JedWatson

@marcofugaro
Copy link

@durran I think also the file lib/Codemirror.js needs to be updated, that is the one being used when you require the library. I don't understand the workflow but you probably need to launch just npm run build

@inoas
Copy link

inoas commented Jul 3, 2017

We are waiting for this (or #107) to merge and considering moving to https://github.com/securingsincity/react-ace if there is nothing happening anytime soon cause we do not want to create a real fork.

@durran
Copy link
Author

durran commented Jul 4, 2017

@marcofugaro I wasn't sure of the workflow as well so figure the build would be handled by @JedWatson before the publish.

@besh
Copy link

besh commented Jul 7, 2017

@JedWatson
Just pinging because it looks like others were pinging with lowercase jedwatson which didn't appear to be performing the @mention.

Many have been needing the changes either in this PR or in #107. Are you open to having others help maintain this repo? We love everything you've done with it so far and I personally wouldn't want to have to rely on a random branch or switch to a different lib.

@christopherdro
Copy link

@JedWatson

@christopherdro
Copy link

Unfortunately this did not solve #106 for me.

@inoas
Copy link

inoas commented Jul 13, 2017

Are you sure?
Does #107 fix it for your @christopherdro

@christopherdro
Copy link

Yes #107 works

@inoas
Copy link

inoas commented Oct 2, 2017

Edit: Please try https://github.com/scniro/react-codemirror2 instead.
That fork is maintained, available via npm and gathering stars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants