-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check next props value against code mirror value #122
base: master
Are you sure you want to change the base?
Conversation
Waiting for this PR to be merged. This solves our problem as well. |
please @JedWatson |
@durran I think also the file |
We are waiting for this (or #107) to merge and considering moving to https://github.com/securingsincity/react-ace if there is nothing happening anytime soon cause we do not want to create a real fork. |
@marcofugaro I wasn't sure of the workflow as well so figure the build would be handled by @JedWatson before the publish. |
@JedWatson Many have been needing the changes either in this PR or in #107. Are you open to having others help maintain this repo? We love everything you've done with it so far and I personally wouldn't want to have to rely on a random branch or switch to a different lib. |
Unfortunately this did not solve #106 for me. |
Are you sure? |
Yes #107 works |
Edit: Please try https://github.com/scniro/react-codemirror2 instead. |
We we having the same issues as described in #121 and #106. In our case, simply checking the next prop's value against the current code mirror value resolved the issue.