Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings with React 15.5.3 #1661

Closed
sebastianiorga opened this issue Apr 11, 2017 · 8 comments
Closed

Deprecation warnings with React 15.5.3 #1661

sebastianiorga opened this issue Apr 11, 2017 · 8 comments

Comments

@sebastianiorga
Copy link

  1. Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
  2. Warning: AutosizeInput: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Solution for first one:

  1. Add prop-types package.
  2. Any file that has 'React.PropTypes' in it: add an import for PropTypes, remove the React. prefix.

Not sure about the exact fix for the second one. I guess adding create-react-class to dependencies if refactoring to classes isn't viable?

Thanks for building this package, dude!
@delveintechnolabs
Copy link

@JedWatson : i see a open PR #1658 . Can you please merge into master. I just updated my react version and started getting errors in console. (I see that travis build has failed on that PR but i am sure that would be a 1 min fix)

Looking forward to a merge and version upgrade.

Thanks

@GitShaffi
Copy link

Facing same issue! Looking forward to a merge and version upgrade.

@akashbdj
Copy link

Same issue. When to expect this fix?

@andrerpena
Copy link

Please!

@haunguyen90
Copy link

Please fix the new deprecation warnings from fb-react

@hiramhibbard
Copy link

I also would love to see this updated as well. I'm a little worried that there haven't been any new commits in over a month.

@MichaelDeBoey
Copy link
Contributor

These are fixed with #1658 and are now released 🙂

@sebastianiorga
Copy link
Author

sebastianiorga commented May 15, 2017 •
edited
Loading

Updated and everything works fine for me. Thank you once again for this great package.

mbautin pushed a commit to mbautin/yugabyte-db that referenced this issue Jul 16, 2019
Remove unused imports/ Change React-Dom to latest version that suppre…
33734d2 
…sses warnings

Summary:
With React-Dom@15.5.0 we are getting warnings React.createClass is deprecated.
We are not using react.createClass in our code-base but some of the dependancies react-bootstrap, react-select use react.createClass and have PR's regarding the same have not been yet been resolved.
JedWatson/react-select#1661
Hence keeping to React, React-Dom versions 15.4.0 until the PR's for React-Bootstrap and React-Select are resolved.

Test Plan:
Go to browser console.
You should not see any console warnings.

Reviewers: karthik, jeff, ram

Reviewed By: ram

Subscribers: jenkins-bot, ui, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@hiramhibbard @andrerpena @MichaelDeBoey @sebastianiorga @akashbdj @haunguyen90 @GitShaffi @delveintechnolabs