Event swallowed when pressing Enter

[kembuco]

Currently pressing enter when the select list isn't open causes the keypress event to be swallowed. Preventing the default behavior of enter when the select list is open seems like the right behavior. However, it prevents things like form submission if the list is closed.

I can submit a pull request with a fix for this. Basically, it just adds an else clause that returns if the select list isn't open.

[dcousens]

Fixed in #212 #213

[sstern6]

This seems to be re occurring in version 1.1.0. On a form with an onSubmit, the enter causes the dropdown to open, and the onSubmit wont fire.

Thanks

[sstern6]

@dcousens youre right, this way fixed in #212, but for some reason on master it was changed. https://github.com/JedWatson/react-select/blob/master/src/Select.js#L454.

[jnachtigall]

@dcousens Looks like a regression. Could this be reopened?

but for some reason on master it was changed. https://github.com/JedWatson/react-select/blob/master/src/Select.js#L454.

@sstern6 this link point to the wrong line now, here's one with a fixed git hash:

react-select/src/Select.js

Lines 487 to 494 in 7bc9363

	case 13: // enter
	event.preventDefault();
	event.stopPropagation();
	if (this.state.isOpen) {
	this.selectFocusedOption();
	} else {
	this.focusNextOption();
	}

<Enter> is always prevented, so the form is never submitted on <Enter>.