Adds onAdd handler

[flovilmart]

As per discussion on #151

[dcousens]

Looks good to me.

Thanks @flovilmart

[dcousens]

Actually, can you change allowCreate to canAdd?

[flovilmart]

Yep. I'll do that. BTW The onAdd fires with the same parameters as onChange.

On Tue, May 19, 2015 at 9:47 PM, Daniel Cousens notifications@github.com
wrote:

Actually, can you change allowCreate to canAdd?

Reply to this email directly or view it on GitHub:
#197 (comment)

[dcousens]

@flovilmart excellent :)

[dcousens]

bump @flovilmart

[flovilmart]

Bump?

[dcousens]

Actually, can you change allowCreate to canAdd?

See flovilmart#2

[dcousens]

@flovilmart anything holding this back?

[brianreavis]

As mentioned in #235, an onAdd event should should be paired with an onRemove, right? Or is this more of an onCreate event? Sorry, I'm a little confused on the terminology here. With the "multi" mode, an onAdd event that really represents when new items are created is going to create confusion.

[flovilmart]

I agree that onCreate would be more appropriate

On Fri, Jun 5, 2015 at 9:26 PM, Brian Reavis notifications@github.com
wrote:

As mentioned in #235, an onAdd event should should be paired with an onRemove, right? Or is this more of an onCreate event? Sorry, I'm a little confused on the terminology here. With the "multi" mode, an onAdd event that really represents when new items are created is going to create confusion.

Reply to this email directly or view it on GitHub:
#197 (comment)

[brianreavis]

@dcousens Your thoughts? @flovilmart Sorry for suggesting we go back and forth on this!

[flovilmart]

No problem. That's a quick fix and it's already on production with my fork :) better do it now!

On Fri, Jun 5, 2015 at 10:35 PM, Brian Reavis notifications@github.com
wrote:

@dcousens Your thoughts? @flovilmart Sorry for suggesting we go back and forth on this!

Reply to this email directly or view it on GitHub:
#197 (comment)

[dcousens]

@brianreavis excellent point, onCreate and onRemove sound fine.

I'll close my PR, @flovilmart are you happy to fix this soon? If not, I'll merge and manually fix. 👍

Thanks for this.

[flovilmart]

Il do it tomorrow.also, the flag should be back to canCreate :)

On Fri, Jun 5, 2015 at 11:16 PM, Daniel Cousens notifications@github.com
wrote:

@brianreavis excellent point, onCreate and onRemove sound fine.
I'll close my PR, @flovilmart are you happy to fix this soon? If not, I'll merge and manually fix. 👍

Thanks for this.

Reply to this email directly or view it on GitHub:
#197 (comment)

[dcousens]

Bump @flovilmart,

[seanmheff]

Bump

[agirton]

Closing as this is no longer applicable.