Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not clearing when given invalid values, from #1756 #2100

Merged
merged 1 commit into from
Oct 26, 2017
Merged

fix not clearing when given invalid values, from #1756 #2100

merged 1 commit into from
Oct 26, 2017

Conversation

gwyneplaine
Copy link
Collaborator

Cleaning up and adding tests to @ticklemynausea's initial PR #1756

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.89% when pulling 8ebda3a on fix/renderClear into ca09183 on master.

@gwyneplaine gwyneplaine mentioned this pull request Oct 26, 2017
Closed
@JedWatson
Copy link
Owner

Thanks

@gwyneplaine it looks like this can be optimised so we don't need to call getValueArray in every render - can you look into a subsequent pr that fixes this?

@JedWatson JedWatson merged commit ad50e62 into master Oct 26, 2017
@JedWatson JedWatson deleted the fix/renderClear branch October 26, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwyneplaine @coveralls @JedWatson