Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint and cleanup warnings. #225

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Conversation

AlexKVal
Copy link
Contributor

@AlexKVal AlexKVal commented Jun 1, 2015

Update eslint dev dependency.
Clean up eslint warnings.
And impose new "object-curly-spacing" rule.

AlexKVal added 2 commits June 1, 2015 14:57
And impose new "object-curly-spacing" rule.
@dcousens
Copy link
Collaborator

dcousens commented Jun 2, 2015

Thanks for this @AlexKVal.

Note we will be switching to adding happiness soon.

See #224 if you want to help out.

dcousens added a commit that referenced this pull request Jun 2, 2015
Update eslint and cleanup warnings.
@dcousens dcousens merged commit 61663a5 into JedWatson:master Jun 2, 2015
@AlexKVal
Copy link
Contributor Author

AlexKVal commented Jun 2, 2015

Good idea.
It is best to maintain one set of rules in one place than maintain rule sets for every project 👍

vagnervjs pushed a commit to vagnervjs/react-select that referenced this pull request Jun 3, 2015
Update eslint and cleanup warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants