Allow entering of commas when allowCreate is on but multi is off. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to help get this reviewed? |
|
Sorry for the delay @adinardi! Somehow missed the notification on this PR when it came in. Might actually be a better long-term solution to make the comma keydown handler option via a prop, but for now if this fix works for you I'll get it released. |
JedWatson
added a commit
that referenced
this pull request
Jul 26, 2015
Allow entering of commas when allowCreate is on but multi is off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keydown handler for commas was introduced in #151, but it is preventing created values from having commas in them.
This allows commas to be included in created values as long as multi isn't enabled.