Separate menu placement logic from menu primitive #2975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for all the white-space changes; prettier had a field day.
Basically this moves the logic for placing and resizing the menu into
MenuPlacer
, which wraps theMenu
primitive (now actually a primitive).Also, menu placement logic now checks the explicit margin value on the menu element rather than pulling the
menuGutter
value from theme.Why?
MenuList
, which was breaking position fixed behaviour when close to the bottom of the viewportNext
Resolves #2965