Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update broken tests #3253

Merged
merged 1 commit into from
Dec 21, 2018
Merged

fix: update broken tests #3253

merged 1 commit into from
Dec 21, 2018

Conversation

theneva
Copy link
Contributor

@theneva theneva commented Dec 5, 2018

Looks like these tests were broken in 6079e9e—I assume they were meant to be updated.

BTW, the CircleCI build is currently failing with:

Build-agent version 0.1.1073-1f69f340 (2018-11-20T18:07:03+0000)
Starting container cypress/base:8
  image is cached as cypress/base:8, but refreshing...

Error response from daemon: unauthorized: authentication required

@Avaq Avaq mentioned this pull request Dec 7, 2018
Merged
8 tasks
@theneva
Copy link
Contributor Author

theneva commented Dec 18, 2018

nudge 😄

This seems to be blocking #3260 now, and it burned me again when I tried to submit another fix.

Would someone please have a look at this PR? ❤️

@gwyneplaine
Copy link
Collaborator

Thanks for this @theneva, merged

@gwyneplaine gwyneplaine merged commit eac850c into JedWatson:master Dec 21, 2018
@xakep139 xakep139 mentioned this pull request Dec 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theneva @gwyneplaine