-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually set 'isLoading' state for async selects #3690
Conversation
ee48fd0
to
0c2d7ec
Compare
There is a related pr already open for this issue, but it has been dormant and sitting with a merge conflict for a few months. It is necessary for my use case to be able to explicitly set the loading property of an asynchronous select. This change keeps the current functionality intact while allowing the loading indicator to be displayed at the discretion of the developer. |
@JedWatson Is it possible for someone to maybe take a look at this? |
I am replying to myself.
|
@JedWatson Please merge. I could really use this so that I can show the loading indicator on AsyncCreatableSelect while onCreateOption is fetching. |
🦋 Changeset is good to goLatest commit: 4cf6c43 We got this. Not sure what this means? Click here to learn what changesets are. |
Looks good, thanks @csilkwor! sorry for the delay merging. Will ship with the next release! |
I am still facing this issue. Not sure it is released yet or not. |
Could this please be released @JedWatson? |
@JedWatson could you do a release with this fix included please? |
It would be greatly appreciated if this could be be released. Thanks for the awesome work with the project! |
This fix would be greatly appreciated! Thanks for a great project! |
I agree with all the previous comments, I'd love to see this released! |
Fixes #2986