-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classNames
API and unstyled
prop
#5457
Changes from all commits
5d960cc
3aee85c
0773095
edf5265
ed2ee59
4cb7b33
3bc3d6d
1d0d22f
2f5f044
153107d
b0eb55c
56a56c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'react-select': minor | ||
'@react-select/docs': patch | ||
--- | ||
|
||
Add classNames API and unstyled prop |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,10 @@ body { | |
} | ||
p > a, | ||
p > a:hover, | ||
p > a:visited { | ||
p > a:visited, | ||
li > a, | ||
li > a:hover, | ||
li > a:visited { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a quick and dirty fix for some links being styled differently in the docs. |
||
color: #2684ff; | ||
} | ||
code { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,8 +105,7 @@ const Heading = (props: HeadingProps) => { | |
store.add(nodeKey, { key: nodeKey, label, level, path: `#${slug}` }); | ||
} | ||
const css = { | ||
marginTop: 0, | ||
'&:not(:first-of-type)': { marginTop: 30 }, | ||
'&:first-child': { marginTop: 0 }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the reason behind changing this (other than simplifying things?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the previous style would result in: // 0
<h1/>
// 0
<h2/>
// 0
<h3/>
// 30
<h2/>
// 30
<h3/> but i think the intention was to just do: // 0
<h1/>
<h2/>
<h3/>
<h2/>
<h3/> |
||
}; | ||
|
||
return linkify ? ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we version docs? Should this be
minor
too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No one is consuming the docs as a package, so I probably wouldn't even worry about versioning it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed it's at version
3.1.2
though, and no idea how it got there 🤷