-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to introduce friction when using the delete key #5669
base: master
Are you sure you want to change the base?
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd8530f:
|
if (backspaceFriction) { | ||
if (focusedValue) { | ||
this.removeValue(focusedValue); | ||
return; | ||
} else { | ||
this.focusValue('previous'); | ||
return; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (backspaceFriction) { | |
if (focusedValue) { | |
this.removeValue(focusedValue); | |
return; | |
} else { | |
this.focusValue('previous'); | |
return; | |
} | |
} | |
if (backspaceFriction && !focusedValue) { | |
this.focusValue('previous'); | |
return; | |
} |
Looking forward for this to getting merged :) |
This feature requires that users hit the backspace key twice when deleting a value, unless the value is already selected.
I created a feature request here: #5670