Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #9 #10

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Fix for issue #9 #10

merged 1 commit into from
Jul 24, 2017

Conversation

JohnCMcDonough
Copy link

No description provided.

@JohnCMcDonough JohnCMcDonough mentioned this pull request Jul 24, 2017
Closed
@Jeff-Lewis Jeff-Lewis merged commit bc1399f into Jeff-Lewis:master Jul 24, 2017
@Jeff-Lewis
Copy link
Owner

@JohnCMcDonough thanks for the PR. Yesterday I thought to add a test for memory leaks as I thought this might be an issue.
I merged your PR as I think removing context based on asyncId is correct. I'm still going to add a test to see if removing the currentUid's (executionAsyncId) context also is appropriate here. I have a feeling it's not 100% of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnCMcDonough @Jeff-Lewis