Cached injector for common modules #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's your use case? Why would you want to share singleton instances across tests? |
|
At least connection pools to DB or some shared state (I know that shared states is bad idea, but sometimes it very helpful) |
|
Ideally you would fake out the DB connection so it isn't terribly expensive, but I can see some value in a feature like this. I don't think it should be enabled by default, but adding some annotation that lets users opt into shared injectors would be reasonable |
|
I add @SharedInjectors annotation for cached inhectors enabled |
JeffFaer
requested changes
Oct 9, 2018
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
JeffFaer
requested changes
Oct 13, 2018
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
guice-extension/src/main/java/name/falgout/jeffrey/testing/junit/guice/GuiceExtension.java
Outdated
Show resolved
Hide resolved
guice-extension/src/test/java/name/falgout/jeffrey/testing/junit/guice/SharedInjectorsTest.java
Outdated
Show resolved
Hide resolved
JeffFaer
approved these changes
Oct 18, 2018
|
Looks good, thanks for bearing with me! |
|
This will be available as part of 1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In original implementantion for each test guice create new injector and if we bind somting in scope SINGLETON - that not work as expected.
In this pr I provide basic implementation of cache for injectors with same modules - can you provide some feedback? @JeffreyFalgout