Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to suppress NotSupportedException for reference linkbases #13

Closed
tmcg opened this issue Jul 12, 2018 · 6 comments
Closed

Ability to suppress NotSupportedException for reference linkbases #13

tmcg opened this issue Jul 12, 2018 · 6 comments

Comments

@tmcg
Copy link

tmcg commented Jul 12, 2018

Hi, I'm attempting to parse some Standard Business Reporting XBRL messages from the Australian Taxation Office but it's failing with NotSupportedException during taxonomy schema validation. If I comment out the exception and recompile, I have no trouble accessing the document contexts and facts.

Their taxonomy commonly uses reference linkbases to point to specific articles of tax legislation, which I'm not interested in and should be ok to ignore for my use case. e.g activity statements lodgement message schema

A proposal might be for Gepsio to pass an "XbrlDocumentParseOptions" to the XbrlDocument that can selectively disable that exception. I could submit an example pull request if it's a good idea?

@JeffFerguson
Copy link
Owner

Hello! I'd like to understand the issue a bit better. Would it be possible to attach a copy of the XBRL that you're trying to parse in a reply so that I can take a closer look?

Thank you for the report!

@tmcg
Copy link
Author

tmcg commented Jul 13, 2018

Hi! thanks for the quick reply

The list response XBRL document is attached - it's public data as part of the ATO conformance testing suite for calling the GST business activity statement lodgement service.

CONF-ATO-AS-001_List_Response_03.xml

The ATO has an SBR Taxonomy Viewer online if that helps also.
The ATO is just a small part of the AU government's Standard Business Reporting web services portal, so for this particular document you just need to drill down into where they're located:
SBR AU -> 1. Current Version -> SBR AU 2018.02.86 -> ATO Activity Statement

@JeffFerguson
Copy link
Owner

JeffFerguson commented Jul 14, 2018

A ha! It seems that you have run into this code in LinkbaseDocumentCollection.cs:

else if (xlinkNode.IsInRole(XbrlDocument.XbrlReferenceLinkbaseReferenceRoleNamespaceUri) == true)
{
    throw new NotSupportedException("No support for reference linkbases.");
}

Sounds like I need to go find that part of the spec and implement that!

Thank you for the report! I will leave this issue open while I build out that support.

@tmcg
Copy link
Author

tmcg commented Jul 16, 2018

Yep, that's the code. In the meantime I've commented out the exception and rebuilt as the legislation references are not critical. Thanks!

@tmcg
Copy link
Author

tmcg commented Jul 25, 2018

brilliant, thanks I'll take a look

@JeffFerguson
Copy link
Owner

JeffFerguson commented Jul 25, 2018

No worries. It's in the develop branch at the moment, and it will be pushed to master and an updated NuGet package released at the beginning of August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants