Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments, dumping, and adding #58

Open
markito3 opened this issue Oct 30, 2018 · 4 comments
Open

comments, dumping, and adding #58

markito3 opened this issue Oct 30, 2018 · 4 comments

Comments

@markito3
Copy link
Member

Subject: | Re: analysis currently broken
Fri, 26 Oct 2018 18:56:39 -0400 (EDT)
Alexander Somov somov@jlab.org
David Lawrence davidl@jlab.org
Beni Zihlmann zihlmann@jlab.org, Mark M. Ito marki@jlab.org, Simon Taylor staylor@jlab.org

Hi,

Simon has just found the problem:

When one dumps the table from the DB (in order to modify/add fields),
the "dump" command does not inhibit # tags, such as

#Restore slot,channel for TAGM column 19, new slot,channel for TAGM

This line(s) has to be removed by hand when you "add" the
modified table.

--

There are no error messages when you "add" a table containing
non-xml tags. I think that we need to ask Dmitry to modify
the "dump" command and "suppress" non-xml characters

All in all, the problem seems to be fixed now (I modified the table)

Cheers,
Sasha

@DraTeots
Copy link
Contributor

It would be very good to have exact commands, that do this (with table names) with our HallD db. Like:

> dump xxx/yyy
> add ...
# and now we have a problem

@markito3
Copy link
Member Author

markito3 commented Oct 31, 2018

I tried and cannot reproduce the problem. It could be that my test case did not address the alleged bug. Could someone provide an example per @DraTeots request, perhaps @somovalex or @staylorjlab?

@staylorjlab
Copy link

The problem is specific to the translation table (xml) at the parsing stage because the "#" symbol outside of < /> is not valid xml and this does not impact other tables where the comment character "#" is harmless.

@sdobbs
Copy link

sdobbs commented Nov 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants