remove odd-number-hit cut for Kalman tracks #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a relic of a time when we were comparing KF-based and ST-based alignments. It is not needed anymore and we should remove this cut so we can use all tracks found by KF, including ones that may have only one sensor from a given module.
2 tasks
|
@tomeichlersmith Status of this? Still WIP ? |
|
I just haven't tested it - it compiles and runs normally if you want to just risk it. |
|
ok. LGTM |
pbutti
approved these changes
Feb 23, 2023
sarahgaiser
approved these changes
Feb 23, 2023
tomeichlersmith
deleted the
944-known-inconsistencies-with-kf-based-alignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a relic of a time when we were comparing KF-based and ST-based alignments. It is not needed anymore and we should remove this cut so we can use all tracks found by KF, including ones that may have only one sensor from a given module.
Still To Do