-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: organize algorithms in subdirectories #206
Conversation
d9c9796
to
e3c862f
Compare
When is the expected merge for this branch? I would like to add the iguana stuff to the clas12root release, but would prefer to wait for this refactorisation if it is going to be soon. |
Early next week, unless we run into any difficult issues here. |
@dglazier CI checks pass now. I will review the changes on Monday; I also requested your review, in case you'd like to take a second look or have any feedback. |
- renamed: src/iguana/algorithms/clas12/PhotonGBTFilter.cc -> src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.cc - renamed: src/iguana/algorithms/clas12/PhotonGBTFilter.h -> src/iguana/algorithms/clas12/PhotonGBTFilter/Algorithm.h - renamed: src/iguana/algorithms/clas12/PhotonGBTFilter.yaml -> src/iguana/algorithms/clas12/PhotonGBTFilter/Config.yaml - renamed: src/iguana/algorithms/clas12/PhotonGBTFilterValidator.cc -> src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.cc - renamed: src/iguana/algorithms/clas12/PhotonGBTFilterValidator.h -> src/iguana/algorithms/clas12/PhotonGBTFilter/Validator.h - renamed: src/iguana/algorithms/machine_learning/photon_gbt/RGA_inbending.cpp -> src/iguana/algorithms/clas12/PhotonGBTFilter/models/RGA_inbending.cpp - renamed: src/iguana/algorithms/machine_learning/photon_gbt/RGA_outbending.cpp -> src/iguana/algorithms/clas12/PhotonGBTFilter/models/RGA_outbending.cpp - renamed: src/iguana/algorithms/machine_learning/photon_gbt/RGC_Summer2022.cpp -> src/iguana/algorithms/clas12/PhotonGBTFilter/models/RGC_Summer2022.cpp
Hi Chris,
Cheers |
The number of files per algorithms has been growing, so the algorithms are now organized into individual subdirectories, with the following files:
Algorithm.{h,cc}
Validator.{h,cc}
Config.yaml
Bindings.cc
Additional changes
iguana-example-*
executables also have been renamed, to exclude the numbersmake_template.sh
has been renamed tomake_starter.sh