Fix overlap issue #613
Merged
Fix overlap issue #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran my simulation with this new develop branch, there were a lot of overlaps detected in the sieve (A screenshot is attached).This is happening because of the nested volume structure that I used to define the sieve holes (the holes are actually nested inside the full solid annulus sieve). In that nested structure, I make the z length of the sieve holes a 1 mm longer than the z thickness of the sieve itself as a cautionary measure on each side. Those overlap problems will go away once you make the two lengths equal. Previously it used to not give any problems but it might be due to the new G4 version (only my guess).