Skip to content

Commit

Permalink
Integration test fix (kubeflow#3357)
Browse files Browse the repository at this point in the history
* try generate MKP binary for each submit

* try run

* fix format

* fix format

* fix format

* it works, gcloud builds submit --config test/cloudbuild/mkp_verify.yaml --project ml-pipeline-test

* test commit trigger

* backup codes

* test

* fix

* pass manual test before submit

* 0.3.0

* quick fix for test path

Co-authored-by: Renmin Gu <renming@google.com>
  • Loading branch information
2 people authored and Jeffwan committed Dec 9, 2020
1 parent 9c075d0 commit 3929cfa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions test/deploy-pipeline-mkp-cli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@


# Test before submit:
# test/deploy-pipline-mkp-cli.sh 0.2 $(git rev-parse HEAD)
# test/deploy-pipline-mkp-cli.sh 0.3 $(git rev-parse HEAD) $(pwd)/test

set -ex

VERSION=$1
COMMIT_SHA=$2
TEST_FOLDER=$3

# sync trigger to avoid wait
gcloud builds submit --config=test/cloudbuild/mkp_verify.yaml --substitutions=_DEPLOYER_VERSION="$VERSION",COMMIT_SHA="$COMMIT_SHA" --project=ml-pipeline-test
gcloud builds submit --config=$TEST_FOLDER/cloudbuild/mkp_verify.yaml --substitutions=_DEPLOYER_VERSION="$VERSION",COMMIT_SHA="$COMMIT_SHA" --project=ml-pipeline-test
2 changes: 1 addition & 1 deletion test/postsubmit-tests-with-pipeline-deployment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,6 @@ if [ ${KFP_DEPLOYMENT} == standalone ]; then
echo "test workflow completed"
else
SEM_VERSION="$(cat ${DIR}/../VERSION)"
source "${DIR}/deploy-pipeline-mkp-cli.sh" $SEM_VERSION $COMMIT_SHA
source "${DIR}/deploy-pipeline-mkp-cli.sh" $SEM_VERSION $COMMIT_SHA ${DIR}
exit $?
fi

0 comments on commit 3929cfa

Please sign in to comment.