use reflect.DeepEqual to compare run structs (kubeflow#3546)

Jeffwan · Dec 9, 2020 · 645e269 · 645e269
1 parent fa159d8
commit 645e269
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/backend/test/integration/run_api_test.go b/backend/test/integration/run_api_test.go
@@ -2,6 +2,7 @@ package integration
 
 import (
 	"io/ioutil"
+	"reflect"
 	"testing"
 	"time"
 
@@ -263,7 +264,7 @@ func (s *RunApiTestSuite) checkTerminatedRunDetail(t *testing.T, runDetail *run_
 		ScheduledAt: runDetail.Run.ScheduledAt,
 		FinishedAt:  runDetail.Run.FinishedAt,
 	}
-	assert.Equal(t, expectedRun, runDetail.Run)
+	assert.True(t, reflect.DeepEqual(expectedRun, runDetail.Run))
 }
 
 func (s *RunApiTestSuite) checkHelloWorldRunDetail(t *testing.T, runDetail *run_model.APIRunDetail, experimentId string, experimentName string, pipelineVersionId string, pipelineVersionName string) {
@@ -292,7 +293,7 @@ func (s *RunApiTestSuite) checkHelloWorldRunDetail(t *testing.T, runDetail *run_
 		ScheduledAt: runDetail.Run.ScheduledAt,
 		FinishedAt:  runDetail.Run.FinishedAt,
 	}
-	assert.Equal(t, expectedRun, runDetail.Run)
+	assert.True(t, reflect.DeepEqual(expectedRun, runDetail.Run))
 }
 
 func (s *RunApiTestSuite) checkArgParamsRunDetail(t *testing.T, runDetail *run_model.APIRunDetail, experimentId string, experimentName string) {
@@ -323,7 +324,7 @@ func (s *RunApiTestSuite) checkArgParamsRunDetail(t *testing.T, runDetail *run_m
 		ScheduledAt: runDetail.Run.ScheduledAt,
 		FinishedAt:  runDetail.Run.FinishedAt,
 	}
-	assert.Equal(t, expectedRun, runDetail.Run)
+	assert.True(t, reflect.DeepEqual(expectedRun, runDetail.Run))
 }
 
 func TestRunApi(t *testing.T) {