Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pep 728 Assure if closed is not passed, the value of __closed__ is None. #1

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

Daraan
Copy link

@Daraan Daraan commented Feb 3, 2025

Hello, I've looked a bit in your draft and the PEP.

I saw that the following was not fulfilled in all places.

If closed is not passed, the value of __closed__ is None.

@Daraan Daraan force-pushed the 3.14/TypedDictExtraItems branch from f13127a to 78f5190 Compare February 3, 2025 17:45
@JelleZijlstra JelleZijlstra merged commit 22c2b6e into JelleZijlstra:pep728 Feb 11, 2025
@JelleZijlstra
Copy link
Owner

Thanks! Sorry I missed this earlier.

@Daraan Daraan deleted the 3.14/TypedDictExtraItems branch February 13, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants