-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign From
derive macro
#241
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
518c1b1
WIP
ilslv 99cb368
Add tests
ilslv a062ce1
Add tests
ilslv 7f24761
Docs and clippy
ilslv 845558e
Fix unit tests
ilslv 6211b1a
Docs
ilslv e5ef86e
Port compile_fail tests from `Display` derive macro
ilslv 8c8f9ca
More compile_fail tests
ilslv 6e82741
CHANGELOG
ilslv 7080be8
Reimplement `core::fmt::DebugTuple` to add support for `finish_non_ex…
ilslv 20a0cb0
Docs fmt corrections
ilslv 8c58553
Minor correction
ilslv 5a8cf3a
Minor correction
ilslv 558c2f0
Minor corrections [skip ci]
tyranron 819454e
Restructure the modules and guard `Debug` under a separate `debug` fe…
ilslv aa2d332
Implement `syn::Type` parsing
ilslv 20d107e
Simplify `syn::Type` parsing with assumptions
ilslv ea8e31c
Attributes parsing
ilslv 50135d4
Merge branch 'master' into from-attribute
ilslv 0b6ca7b
WIP
ilslv ce2cd00
WIP
ilslv 61f1a16
WIP
ilslv 0d489d6
Implementation that covers all existing test cases
ilslv 382f185
Exhaustively cover struct with unit tests
ilslv eac8e27
Exhaustively cover enum and generics with unit tests
ilslv 1ee8c09
More unit tests for generic structs
ilslv ef8fa47
More unit tests for generic enums
ilslv f4f874b
More unit tests for generics
ilslv 7df415e
More unit tests for generics
ilslv 87e1058
More unit tests for generics
ilslv eaa3596
Add compile fail tests
ilslv ff47628
Skip variants without attributes if another variant has `#[from]` or …
ilslv 9680277
Docs
ilslv e5f6540
Docs
ilslv 295eb0d
Docs and corrections
ilslv 60430f7
Merge branch 'master' into from-attribute
ilslv c5b1f77
Clippy
ilslv 14e8361
Corrections
ilslv 1d74fdf
Corrections and changelog
ilslv 249a92c
Corrections
ilslv 4006a78
Merge branch 'master' into from-attribute
ilslv ebf41ed
Corrections
ilslv ea0cd04
Merge branch 'master' into from-attribute
ilslv a78f124
Merge branch 'master' into from-attribute
tyranron ec48a37
Minor corrections
tyranron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't realize this changed until I read this changelog entry. Sorry for not noticing earlier, because it's indeed in the PR description. But I don't think we should remove the
types
wrapper itself. This will make it hard for us to add new sub-attributes to thefrom
attribute in a backwards compatible manner in the future, because although unlikely they might conflict with type names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear this comment was about removing the
types
wrapper. "Ignoring the field type itself" I'm also not a huge fan of, but I think that's fine.