Use the new parsing utils #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
approved these changes
Aug 22, 2023
impl/src/utils.rs
Outdated
| @@ -1385,6 +1397,31 @@ pub(crate) mod skip { | |||
| /// ``` | |||
| pub(crate) struct Attribute(&'static str); | |||
|
|
|||
| impl Attribute { | |||
There was a problem hiding this comment.
@MegaBluejay why as a separate impl Attribute block? There is one already down bellow.
| @@ -1385,6 +1397,31 @@ pub(crate) mod skip { | |||
| /// ``` | |||
| pub(crate) struct Attribute(&'static str); | |||
|
|
|||
| impl Attribute { | |||
| pub(crate) fn parse_attrs( | |||
There was a problem hiding this comment.
@MegaBluejay why without docs, again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First suggested here
Synopsis
There's some repetition around parsing the same attributes in different derives
Solution
Refactor
Into,From, andDebugderives to use theskipandforwardattribute parsing utilsChecklist