Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

128: Remove form data #135

Merged
merged 1 commit into from
Apr 9, 2024
Merged

128: Remove form data #135

merged 1 commit into from
Apr 9, 2024

Conversation

JensAstrup
Copy link
Owner

No description provided.

@JensAstrup JensAstrup linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Apr 9, 2024

The changes made in the pull request involve updates to the GitHub Actions workflow, package.json, and yarn.lock files. Here's a summary and review of the changes:

  1. GitHub Actions Workflow (tests.js.yml):

    • The workflow triggers have been expanded to include the tests/ directory and package.json file changes. This ensures that tests are run not only when source code changes but also when test files or dependencies change, which is a good practice to keep tests in sync with the codebase and dependencies.
  2. package.json:

    • The dependency formdata-node has been removed. This change should ideally be accompanied by justification, especially if formdata-node is no longer used in the project, ensuring there's no leftover code that depends on it. The removal might be aiming to clean up dependencies, which is generally positive for maintaining the project's health.
  3. yarn.lock:

    • Corresponding changes in yarn.lock reflect the removal of formdata-node. It's important to keep yarn.lock updated with package.json to ensure that dependency resolution is consistent across environments. This change correctly follows the modification in package.json.

Recommendations:

  • Ensure that all places in the codebase that previously used formdata-node have been updated or removed to avoid runtime errors.
  • Verify that tests and the application's functionality are not affected by the removal of formdata-node.
  • It might be beneficial to include a brief explanation in the pull request description about why formdata-node was removed for better context to reviewers and future maintainers.

Overall, the modifications enhance the project configuration by refining the triggers for workflow actions and cleaning up dependencies, assuming formdata-node is indeed not required anymore.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (4695571) to head (3791e35).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #135   +/-   ##
========================================
  Coverage    91.48%   91.48%           
========================================
  Files           42       42           
  Lines         1785     1785           
  Branches       100      100           
========================================
  Hits          1633     1633           
  Misses         152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JensAstrup JensAstrup merged commit 6bc25f0 into develop Apr 9, 2024
7 checks passed
@JensAstrup JensAstrup deleted the 128-remove-form-data branch April 9, 2024 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Form Data
1 participant