Improve Value.Type

Switch to asserts, which cuts the cost of getting array and array segment type info down to 2.5ns.
JeremyKuhne · Jul 12, 2024 · 6aecd51 · 6aecd51
1 parent 6b85d48
commit 6aecd51
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/ValuePrototype/Value.cs b/ValuePrototype/Value.cs
@@ -13,7 +13,6 @@ public Value(object? value)
 
     public readonly Type? Type
     {
-        [SkipLocalsInit]
         get
         {
             Type? type;
@@ -29,8 +28,10 @@ public readonly Type? Type
             {
                 type = _object.GetType();
 
-                if (_union.UInt64 != 0 && type.IsArray)
+                if (_union.UInt64 != 0)
                 {
+                    Debug.Assert(type.IsArray);
+
                     // We have an ArraySegment
                     if (type == typeof(byte[]))
                     {
@@ -42,7 +43,7 @@ public readonly Type? Type
                     }
                     else
                     {
-                        ThrowInvalidOperation();
+                        Debug.Fail($"Unexpected type {type.Name}.");
                     }
                 }
             }