(GH-476) Do not clone the Json serialization options to avoid problem…

…s when library targets .net6 and is being used in a .net7 application Resolves #476
Jericho · Nov 13, 2022 · 6910a38 · 6910a38
1 parent 0860042
commit 6910a38
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/Source/StrongGrid/Json/BaseJsonConverter{T}.cs b/Source/StrongGrid/Json/BaseJsonConverter{T}.cs
@@ -95,10 +95,11 @@ internal void WriteJsonProperty(Utf8JsonWriter writer, string propertyName, obje
 
 			if (propertyConverterAttribute != null)
 			{
-				// It's important to clone the options in order to be able to modify the 'Converters' list
-				var clonedOptions = new JsonSerializerOptions(options);
-				clonedOptions.Converters.Add((JsonConverter)Activator.CreateInstance(propertyConverterAttribute.ConverterType));
-				JsonSerializer.Serialize(writer, propertyValue, propertyType, clonedOptions);
+				var customOptions = new JsonSerializerOptions()
+				{
+					Converters = { (JsonConverter)Activator.CreateInstance(propertyConverterAttribute.ConverterType) }
+				};
+				JsonSerializer.Serialize(writer, propertyValue, propertyType, customOptions);
 			}
 			else
 			{