Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add daily usage report. #362

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Add daily usage report. #362

merged 3 commits into from
Oct 13, 2024

Conversation

eminmesic
Copy link
Contributor

@eminmesic eminmesic commented Oct 1, 2024 •
edited
Loading

Jericho
Jericho requested changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looking forward to including it in the next release.

Source/ZoomNet/Models/DateObject.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Models/DateObject.cs Outdated Show resolved Hide resolved
@Jericho Jericho added the Enhancement New feature or request label Oct 11, 2024
@Jericho
Copy link
Owner

Jericho commented Oct 11, 2024

@eminmesic Are you still working on this PR or is it completed?

@Jericho Jericho self-assigned this Oct 13, 2024
@Jericho
Copy link
Owner

Jericho commented Oct 13, 2024

This PR, as it stands, does not compile. DateOnly is not available in some of the frameworks supported by ZoomNet. I haven't heard back from @eminmesic so I will take over this PR.

@Jericho Jericho merged commit 54a6f64 into Jericho:develop Oct 13, 2024
0 of 2 checks passed
Jericho added a commit that referenced this pull request Oct 13, 2024
@Jericho
(GH-362) Fix formatting
e6c13f5
Jericho added a commit that referenced this pull request Oct 13, 2024
@Jericho
(GH-362) Change the name of the 'Dates' property in the DailyUsageRep…
106f060 
…ort model to 'DailyUsageSummaries'
Jericho added a commit that referenced this pull request Oct 13, 2024
@Jericho
(GH-362) Replace DateOnly with (int Year, int Month, int Day))
847b0fb
@Jericho Jericho added this to the 0.81.0 milestone Oct 13, 2024
@Jericho
Copy link
Owner

Jericho commented Oct 13, 2024

🎉 This issue has been resolved in version 0.81.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jericho Jericho Jericho requested changes

Assignees

@Jericho Jericho

Labels
Enhancement New feature or request
Projects
None yet
Milestone
0.81.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eminmesic @Jericho