Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add users to group #367

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

SyedShahbaz
Copy link
Contributor

Adds a method AddUserToGroupAsync to add user to user group.

@Jericho Jericho added this to the 0.82.0 milestone Oct 18, 2024
@Jericho Jericho added the Enhancement New feature or request label Oct 18, 2024
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you submission. I look forward to merging it to the library.

Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
@SyedShahbaz SyedShahbaz requested a review from Jericho October 20, 2024 13:55
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing the signature of the AddUsersToGroupAsync method. I think we can simplify the code in this method a little.

Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
Source/ZoomNet/Resources/Groups.cs Outdated Show resolved Hide resolved
@Jericho
Copy link
Owner

Jericho commented Oct 20, 2024

Excellent thank you for making all these changes. I will publish a beta of the library with your changes in a few hours when I'm back at my desk. Hopefully you'll be able to test it and make sure it works as expected.

@SyedShahbaz
Copy link
Contributor Author

Excellent thank you for making all these changes. I will publish a beta of the library with your changes in a few hours when I'm back at my desk. Hopefully you'll be able to test it and make sure it works as expected.

Sure, thanks for the suggestions and let me know if anything needs to be updated

@SyedShahbaz SyedShahbaz requested a review from Jericho October 20, 2024 20:41
Copy link
Owner

@Jericho Jericho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thank you for your contribution.

@Jericho Jericho merged commit d635e4c into Jericho:develop Oct 21, 2024
1 of 2 checks passed
@Jericho
Copy link
Owner

Jericho commented Oct 21, 2024

Uploaded a beta package called ZoomNet 0.82.0-alpha.3 to my personal NuGet feed (instructions). Let know if you have a chance to test both the Groupds.AddUserToGroupAsync and Groups.AddUsersToGroupAsync methods. Thanks.

@SyedShahbaz
Copy link
Contributor Author

Uploaded a beta package called ZoomNet 0.82.0-alpha.3 to my personal NuGet feed (instructions). Let know if you have a chance to test both the Groupds.AddUserToGroupAsync and Groups.AddUsersToGroupAsync methods. Thanks.

Thanks, I will test it and will get back to you

@Jericho
Copy link
Owner

Jericho commented Oct 25, 2024

Have you had a chance to test the beta package?

@SyedShahbaz
Copy link
Contributor Author

Have you had a chance to test the beta package?

Sorry for the delay. I have tested the functionality with the beta package it works as expected!

@Jericho
Copy link
Owner

Jericho commented Oct 26, 2024

Thank you for confirming. I am proceeding with the release.

@Jericho
Copy link
Owner

Jericho commented Oct 26, 2024

🎉 This issue has been resolved in version 0.82.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@MaiklSemenov MaiklSemenov deleted the feature/add-users-to-group branch December 23, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants