-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add users to group #367
Feature/add users to group #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you submission. I look forward to merging it to the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for changing the signature of the AddUsersToGroupAsync method. I think we can simplify the code in this method a little.
Excellent thank you for making all these changes. I will publish a beta of the library with your changes in a few hours when I'm back at my desk. Hopefully you'll be able to test it and make sure it works as expected. |
Sure, thanks for the suggestions and let me know if anything needs to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you for your contribution.
Uploaded a beta package called |
Thanks, I will test it and will get back to you |
Have you had a chance to test the beta package? |
Sorry for the delay. I have tested the functionality with the |
Thank you for confirming. I am proceeding with the release. |
🎉 This issue has been resolved in version 0.82.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Adds a method
AddUserToGroupAsync
to add user to user group.