feat: ✨ --theme gitmoji => opt-in flag feature (non-breaking) #3
Conversation
Add as an opt-in (non-breaking change) to out of the box customize `git-cz` without incurring overhead on custom implementations (if you use this at scale).
There was a problem hiding this comment.
Nice to see the code from a different perspective.
Request is made throughout to not implement as a one-off, and instead move to a theme basis where default|gitmoji would be the first (only?) two available.
I am "fine" with this as-is to be honest as it suits my personal needs perfectly, however, want to think more outside of the box a bit I guess.
There are some updates to the release-notes-generator that may need to happen now with customizations which is what I kind of want to avoid.
So since that would be out-of-scope of the implementation plan, may just see how it works (if at all) with existing overrides before spending too much time porting over writer/parserOpts as want this to be as close to default behavior as possible.
| if (cliOptions.format) { | ||
| options.format = cliOptions.format; |
There was a problem hiding this comment.
Legit think this fixes an existing bug. 🐛
JeromeFitz
changed the title
Also test `experiment` in release notes generator
And let's see what `mv` does :D
Also very sober just more testing of conventional-commits from gitmoji
I _was_ going to rewrite the tests to pull from configuration files however are these hard-coded at the moment because they should not be?
Can still be manually override by `git-cz --theme gitmoji` however I imagine for `git-cz` we would like to keep things consistent.
JeromeFitz
changed the title
|
Merging for I understand whole-heartedly about the configuration file for global config. With so many people using |
|
🎉 This PR is included in version 5.0.0-canary.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0-main.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
✨️ Theme
😎️ Gitmoji
Add as an opt-in (non-breaking change) to out of the box customize
git-czwithout incurring overhead on custom implementations (if you use this at scale).TODO
cli --gitmoji (flag)--theme=>stringwhich defaults todefaultif nothing else passedverify--gitmojiverify.git-cz.json--theme gitmoji.git-cz.json=> `'theme':'gitmoji'release note sections enhancement for expanded emoji listNot neededsection titlesNot neededtype(scope)=>emoji(scope)🐛 subjectout of scope🐛(scope) subjectout of scope