Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 NICE-135 limit for recently-played [b] #3167

Merged
merged 3 commits into from
Jan 19, 2025
Merged

🐛 NICE-135 limit for recently-played [b] #3167

merged 3 commits into from
Jan 19, 2025

Conversation

JeromeFitz
Copy link
Owner

Use 1 for Homepage (Homepage)
Use 50 for Currently (Recently Played)

API only allows going back ~50 records (which is the limit). Instead of finagling a way to dynamically load based on cursors.before|after do the above.

If we ever want to limit back down to 10 and cycle through do some finagling via:

# get last item time in ms (add 000)
before: `${getUnixTime(_last(data).played_at)}000`

@JeromeFitz JeromeFitz changed the title 🐛 NICE-135 limit for recently-played 🐛 NICE-135 limit for recently-played [b] Jan 19, 2025
@JeromeFitz JeromeFitz added the 🥳️ LGTM Automerge: Let's Get This Merged label Jan 19, 2025
@kodiakhq kodiakhq bot merged commit b974b90 into main Jan 19, 2025
2 checks passed
@kodiakhq kodiakhq bot deleted the NICE-135 branch January 19, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant