Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose convergence criteria in function calls #111

Closed
luisfabib opened this issue Mar 23, 2021 · 0 comments · Fixed by #112
Closed

Expose convergence criteria in function calls #111

luisfabib opened this issue Mar 23, 2021 · 0 comments · Fixed by #112
Labels
bug Something isn't working
Milestone
0.13.0

Comments

@luisfabib
Copy link
Collaborator

Convergence criteria such as iterations limit and tolerance values are hard-coded into the program. Some function in DeerLab expose these options as keyword argument while other do not.

Functions exposing options: fitparamodel, snlls,

Functions missing exposure: fitmodel,fitmultimodel.fitregmodel

This must be corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Expose convergence criteria keyword arguments to all fit functions JeschkeLab/DeerLab
1 participant
@luisfabib