Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose convergence criteria keyword arguments to all fit functions #112

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Expose convergence criteria keyword arguments to all fit functions #112

merged 1 commit into from
Mar 23, 2021

Conversation

luisfabib
Copy link
Collaborator

@luisfabib luisfabib commented Mar 23, 2021 •
edited
Loading

Add the keyword arguments tol and maxiter to all fit functions missing them.

Closes #111

@luisfabib luisfabib added the bugfix Patches something that isn't working label Mar 23, 2021
@luisfabib luisfabib added this to the 0.13.0 milestone Mar 23, 2021
@luisfabib luisfabib requested a review from stestoll March 23, 2021 08:56
@luisfabib luisfabib linked an issue Mar 23, 2021 that may be closed by this pull request
Expose convergence criteria in function calls #111
Closed
@luisfabib luisfabib merged commit abcea1b into main Mar 23, 2021
@luisfabib luisfabib deleted the fix/convergence_criteria branch March 23, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stestoll stestoll stestoll approved these changes

Assignees
No one assigned
Labels
bugfix Patches something that isn't working
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

Expose convergence criteria in function calls
2 participants
@luisfabib @stestoll