Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect normalization factor for 3D Rice distribution #459

Closed
stestoll opened this issue Sep 3, 2023 · 0 comments
Closed

Incorrect normalization factor for 3D Rice distribution #459

stestoll opened this issue Sep 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@stestoll
Copy link
Collaborator

stestoll commented Sep 3, 2023

The normalization of the Rice function in

def _multirice3dfun(r,nu,sig):

is incorrect.

The first factor in

 P = nu**(n/2-1)/s2*r**(n/2)*np.exp(-(r**2+nu**2)/(2*s2)+nu*r/s2)*I_scaled

should be

 P = nu**(1-n/2)/s2*r**(n/2)*np.exp(-(r**2+nu**2)/(2*s2)+nu*r/s2)*I_scaled

Overall, this error has no effect, since P is numerically normalized afterwards.

@stestoll stestoll added the bug Something isn't working label Sep 3, 2023
HKaras added a commit that referenced this issue Sep 4, 2023
@HKaras HKaras closed this as completed in b9b76e4 Sep 6, 2023
HKaras added a commit that referenced this issue Nov 3, 2023
* Increase version number and update changelog (#455)

* Bugfixes 4th sep (#460)

* Fix normalisation in rice model

Closes #459

* Remove three spin anaysis

Closes #427

* Improved installation instructions

* Caution about difference in definition of cost function

Closes #450

* Bump Version

* Bug for non linearly constrained problems

When a problem is not linearly constrained and not non-negative, the linear solver outputs a result class not the solution.

* Keeping changelog up-to date

* Fixing Sophgrid bug (#464)

* Fixing Sophgrid bug

* Add unit test for sophgrid

* Update changelog.rst for new release (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant